Add Windows path updates for uv tool
#5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/winreg
branch
5 times, most recently
from
eeecfad
to
7682639
Compare
charliermarsh
force-pushed
the
charlie/winreg
branch
from
7682639
to
cff3dc4
Compare
charliermarsh
commented
Jul 13, 2024
| @@ -151,6 +151,7 @@ urlencoding = { version = "2.1.3" } | |||
| walkdir = { version = "2.5.0" } | |||
| which = { version = "6.0.0" } | |||
| winapi = { version = "0.3.9", features = ["fileapi", "handleapi", "ioapiset", "winbase", "winioctl", "winnt"] } | |||
| winreg = { version = "0.52.0" } | |||
There was a problem hiding this comment.
Already in our dependency tree. I'd slightly rather use winapi if possible but rustup uses winreg and it's just a pain to translate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Largely based on rustup's implementation (linked in the source).
Closes #5027.
Test Plan
uv/foo.foo.